[GitHub] [hadoop] rdingankar commented on a diff in pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-17 Thread via GitHub
rdingankar commented on code in PR #5556: URL: https://github.com/apache/hadoop/pull/5556#discussion_r1169036218 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableMetrics.java: ## @@ -52,6 +52,8 @@ public class TestMutableMetrics {

[GitHub] [hadoop] rdingankar commented on a diff in pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-14 Thread via GitHub
rdingankar commented on code in PR #5556: URL: https://github.com/apache/hadoop/pull/5556#discussion_r1167293044 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java: ## @@ -130,11 +129,11 @@ public MutableQuantiles() {}

[GitHub] [hadoop] rdingankar commented on a diff in pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-14 Thread via GitHub
rdingankar commented on code in PR #5556: URL: https://github.com/apache/hadoop/pull/5556#discussion_r1167293176 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableMetrics.java: ## @@ -431,6 +431,46 @@ public void

[GitHub] [hadoop] rdingankar commented on a diff in pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-14 Thread via GitHub
rdingankar commented on code in PR #5556: URL: https://github.com/apache/hadoop/pull/5556#discussion_r1167293044 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java: ## @@ -130,11 +129,11 @@ public MutableQuantiles() {}