sahilTakiar commented on a change in pull request #1827: HADOOP-16835. Recover
from all failures loading openssl native libs.
URL: https://github.com/apache/hadoop/pull/1827#discussion_r375390095
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/DelegatingSSLSocketFactory.java
##########
@@ -167,6 +167,15 @@ private void initializeSSLContext(SSLChannelMode
preferredChannelMode)
LOG.debug("Failed to load OpenSSL. Falling back to the JSSE default.");
ctx = SSLContext.getDefault();
channelMode = SSLChannelMode.Default_JSSE;
+ } catch (Exception e) {
Review comment:
should we remove the `catch` block for the `NoSuchAlgorithmException` and
just let all exceptions be handled by the same block? these changes look useful
for the `NoSuchAlgorithmException` as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
