[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966506216 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NamespaceStateId.java: ## @@ -0,0 +1,42 @@ +/** Review Comment: I've removed it.

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966375731 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -0,0 +1,89 @@ +/** + * Licensed

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966303059 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederatedNamespaceIds.java: ## @@ -0,0 +1,78 @@ +/** Review

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966302346 ## hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml: ## @@ -6446,4 +6446,11 @@ frequently than this time, the client will give up waiting.

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966200688 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -368,8 +370,20 @@ private

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966184747 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java: ## @@ -349,6 +349,9 @@ public static ClientProtocol

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966175313 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederatedNamespaceIds.java: ## @@ -0,0 +1,113 @@ +/** + *

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966173059 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java: ## @@ -40,6 +40,14 @@ public class ClientGSIContext implements

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966172679 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java: ## @@ -40,6 +40,14 @@ public class ClientGSIContext implements

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966172015 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java: ## @@ -37,7 +37,9 @@ private RpcConstants() { public static

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r966164910 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java: ## @@ -252,21 +252,21 @@ public class

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r964314207 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java: ## @@ -66,15 +75,24 @@ public void

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r964308328 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederatedNamespaceIds.java: ## @@ -0,0 +1,113 @@ +/** + *

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r964306464 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederatedNamespaceIds.java: ## @@ -0,0 +1,113 @@ +/** + *

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r964156460 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterStateIdContext.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r964131419 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederatedNamespaceIds.java: ## @@ -0,0 +1,113 @@ +/** + *

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r943730742 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FederatedNamespaceIds.java: ## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r943730742 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FederatedNamespaceIds.java: ## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r943726586 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FederatedNamespaceIds.java: ## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r943725929 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java: ## @@ -66,15 +79,23 @@ public void

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r924008090 ## hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto: ## @@ -91,6 +91,7 @@ message RpcRequestHeaderProto { // the header for the RpcRequest

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r923612743 ## hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto: ## @@ -91,6 +91,7 @@ message RpcRequestHeaderProto { // the header for the RpcRequest

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r923567042 ## hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto: ## @@ -91,6 +91,7 @@ message RpcRequestHeaderProto { // the header for the RpcRequest

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r898503159 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java: ## @@ -349,6 +349,18 @@ public static ClientProtocol

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

simbadzina commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r898452709 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java: ## @@ -349,6 +349,18 @@ public static ClientProtocol