simbadzina opened a new pull request, #5145: URL: https://github.com/apache/hadoop/pull/5145
HDFS-16847: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException. ### Description of PR The file based implementation of the RBF state store has a commit step that moves a temporary file to a permanent location. There is a check to see if the write of the temp file was successfully, however, the code to commit doesn't check the success flag. This is the relevant code: https://github.com/apache/hadoop/blob/7d39abd799a5f801a9fd07868a193205ab500bfa/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java#L369 ### How was this patch tested? Ran tests in TestStateStoreFileSystem ### For code changes: - [ X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
