[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971426352 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971425926 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971414849 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971358346 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971358259 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-12 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r969057224 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-12 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r969056894 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-12 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r969053578 ## hadoop-project/pom.xml: ## @@ -185,7 +185,7 @@ 1.0-beta-1 900 1.12.262 -2.3.4 +2.5.2 Review Comment: Thank you very much for helping to

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-12 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r968145834 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/MySQL/FederationStateStoreTables.sql: ## @@ -36,7 +36,7 @@ CREATE TABLE membership( state varchar(32)

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-12 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r967601401 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/MySQL/FederationStateStoreTables.sql: ## @@ -36,7 +36,7 @@ CREATE TABLE membership( state varchar(32)

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-10 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r967602319 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-10 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r967602276 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/sql/TestFDMySQLAccuracy.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-10 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r967601774 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/SQLServer/FederationStateStoreTables.sql: ## @@ -140,7 +140,7 @@ IF NOT EXISTS ( SELECT * FROM

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-09 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r967601774 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/SQLServer/FederationStateStoreTables.sql: ## @@ -140,7 +140,7 @@ IF NOT EXISTS ( SELECT * FROM

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-09 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r967601401 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/MySQL/FederationStateStoreTables.sql: ## @@ -36,7 +36,7 @@ CREATE TABLE membership( state varchar(32)

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-06 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r964259520 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/MySQL/FederationStateStoreTables.sql: ## @@ -36,7 +36,7 @@ CREATE TABLE membership( state varchar(32)