slfan1989 commented on PR #4462:
URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1313049922
@aajisaka Thank you very much for helping to review the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
slfan1989 commented on PR #4462:
URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1306452399
@aajisaka Can you help review the code again? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slfan1989 commented on PR #4462:
URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1290216097
@aajisaka Can you help review the code again? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slfan1989 commented on PR #4462:
URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1276982850
@aajisaka Can you help review the code again? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slfan1989 commented on PR #4462:
URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1274282021
> @slfan1989 Thank you for your patch. Would you make the getter method
package-private? I'm +1 if that is addressed.
Thank you very much for your help to review the code, I will
slfan1989 commented on PR #4462:
URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1274210514
@aajisaka Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
slfan1989 commented on PR #4462:
URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1272230510
@aajisaka Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
slfan1989 commented on PR #4462:
URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1179464334
@steveloughran @aajisaka Please help to review the code, I hope that
Whitebox can be completely removed from the mapreduce module.
--
This is an automated message from the Apache Git
slfan1989 commented on PR #4462:
URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1163660746
@jojochuang please help to review the code, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
