[GitHub] [hadoop] slfan1989 commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-08-09 Thread GitBox
slfan1989 commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1209964235 @goiri Thank you very much for your help reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] slfan1989 commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-08-07 Thread GitBox
slfan1989 commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1207436395 @goiri Can you help to merge this pr into trunk branch? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] slfan1989 commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-08-01 Thread GitBox
slfan1989 commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1201840963 > There are a few unused imports. Thanks for the reminder, I will remove this part. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] slfan1989 commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-27 Thread GitBox
slfan1989 commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1196853100 @goiri Please help me to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and