[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1282525269 @dineshchitlangia Thank you very much for your help reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1272234153 @dineshchitlangia Can you help review this pr? Thank you very much! `DisableEventTypeMetrics` doesn't have any references and can be removed, remove this class and all unit tests pass

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1249135045 @ayushtkn Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1247629168 @ayushtkn Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1225870451 @ayushtkn Can you help review this pr? I want to delete DisableEventTypeMetrics.java because this class is not used. Thank you very much! -- This is an automated message from th

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1223711957 @tomscut @Hexiaoqiao @ayushtkn Can you help review this pr? I want to delete DisableEventTypeMetrics.java because this class is not used. Thank you very much! -- This is an auto

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1221723661 @ayushtkn Can you help review this pr? I want to delete DisableEventTypeMetrics.java because this class is not used. Thank you very much! -- This is an automated message from the Ap

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1215125582 @ayushtkn Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1210885913 @ayushtkn Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U