[GitHub] [hadoop] steveloughran commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-02-21 Thread via GitHub
steveloughran commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1113171936 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1919,6 +1933,19 @@ public Collection getAllStoragePol

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-02-21 Thread via GitHub
steveloughran commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1113169004 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java: ## @@ -1638,6 +1638,24 @@ public MultipartUploaderBuilder creat

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2022-10-10 Thread GitBox
steveloughran commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r991490790 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -4877,12 +4877,21 @@ public CompletableFuture build() throws IOExc

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2022-10-10 Thread GitBox
steveloughran commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r991489491 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ClientNamenodeProtocol.proto: ## @@ -428,6 +428,14 @@ message GetPreferredBlockSizeResponseProto { message