[GitHub] [hadoop] steveloughran commented on a diff in pull request #5364: HDFS-16911. Distcp with snapshot diff to support Ozone filesystem.

steveloughran commented on code in PR #5364: URL: https://github.com/apache/hadoop/pull/5364#discussion_r1146801468 ## hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpSync.java: ## @@ -1303,12 +1303,13 @@ public void testSyncSnapshotDiffWithDummyFileSy

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5364: HDFS-16911. Distcp with snapshot diff to support Ozone filesystem.

steveloughran commented on code in PR #5364: URL: https://github.com/apache/hadoop/pull/5364#discussion_r1144815944 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java: ## @@ -161,20 +161,32 @@ private void checkFilesystemSupport(Path sourceDir, P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5364: HDFS-16911. Distcp with snapshot diff to support Ozone filesystem.

steveloughran commented on code in PR #5364: URL: https://github.com/apache/hadoop/pull/5364#discussion_r1137750976 ## hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpSync.java: ## @@ -1276,4 +1283,63 @@ private void snapshotDiffWithPaths(Path sourceFS

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5364: HDFS-16911. Distcp with snapshot diff to support Ozone filesystem.

steveloughran commented on code in PR #5364: URL: https://github.com/apache/hadoop/pull/5364#discussion_r1098966272 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java: ## @@ -165,6 +169,23 @@ private boolean preSyncCheck() throws IOException {