[GitHub] [hadoop] steveloughran commented on a diff in pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

steveloughran commented on code in PR #5563: URL: https://github.com/apache/hadoop/pull/5563#discussion_r1178915082 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABlockOutputArray.java: ## @@ -107,13 +108,18 @@ public void testDiskBlockCreate() throws

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

steveloughran commented on code in PR #5563: URL: https://github.com/apache/hadoop/pull/5563#discussion_r1175384535 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABlockOutputArray.java: ## @@ -79,6 +80,42 @@ public void testRegularUpload() throws IOExc

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

steveloughran commented on code in PR #5563: URL: https://github.com/apache/hadoop/pull/5563#discussion_r1170129401 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java: ## @@ -726,7 +726,7 @@ public void hsync() throws IOException { /**

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

steveloughran commented on code in PR #5563: URL: https://github.com/apache/hadoop/pull/5563#discussion_r1170131112 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestDataBlocks.java: ## @@ -51,7 +51,7 @@ public void testByteBufferIO() throws Throwable {