[GitHub] [hadoop] steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp

2020-01-06 Thread GitBox
steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#issuecomment-571225773 sorry, my mistake. Thought this was in and was doing soem more reviews. Ignore that. I'm just trying to run through

[GitHub] [hadoop] steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-24 Thread GitBox
steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#issuecomment-534495672 +1, committed I did some minor tuning before the commit' * move an import in one of the tests to be in the

[GitHub] [hadoop] steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-11 Thread GitBox
steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#issuecomment-530420060 > With this new patch it fails with blocks not found exception as we are forcing it to read till a particular length

[GitHub] [hadoop] steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-10 Thread GitBox
steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#issuecomment-530081623 +one of the warnings on RetriableFileCopyCommand.java:300 is about an existing issue on the line you've edited. You

[GitHub] [hadoop] steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-10 Thread GitBox
steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#issuecomment-530080808 checkstyle: ignore the "More than 7 parameters" warning; for the others address them *unless* the line length is abo

[GitHub] [hadoop] steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-10 Thread GitBox
steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#issuecomment-529899434 * I did a detailed review on this through vs.code but it managed to lose them all, which is a pain. I'll go through