[GitHub] [hadoop] steveloughran commented on issue #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos.

2019-10-28 Thread GitBox
steveloughran commented on issue #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos. URL: https://github.com/apache/hadoop/pull/1640#issuecomment-546912042 ok. You need to run the full test suite against a live service and declare which location/endpoint you tested with

[GitHub] [hadoop] steveloughran commented on issue #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos.

2019-10-23 Thread GitBox
steveloughran commented on issue #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos. URL: https://github.com/apache/hadoop/pull/1640#issuecomment-545529030 Most of the changes look good; that input stream cleanup looks like it will break the code as a closed stream will always get