[GitHub] [hadoop] steveloughran commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren…

2019-10-23 Thread GitBox
steveloughran commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren… URL: https://github.com/apache/hadoop/pull/1664#issuecomment-545502822 LGTM; thanks for changes +1 and merged to trunk -

[GitHub] [hadoop] steveloughran commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren…

2019-10-22 Thread GitBox
steveloughran commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren… URL: https://github.com/apache/hadoop/pull/1664#issuecomment-545060086 Code LGTM; some minor comments about tests I'd like AbstractS3ATokenIdentifier to create a Text() if a