[GitHub] [hadoop] steveloughran commented on issue #1754: HADOOP-16751: DurationInfo text parsing/formatting should be moved out of hotpath

2020-01-02 Thread GitBox
steveloughran commented on issue #1754: HADOOP-16751: DurationInfo text parsing/formatting should be moved out of hotpath URL: https://github.com/apache/hadoop/pull/1754#issuecomment-570271159 merged to trunk; thanks This is

[GitHub] [hadoop] steveloughran commented on issue #1754: HADOOP-16751: DurationInfo text parsing/formatting should be moved out of hotpath

2020-01-02 Thread GitBox
steveloughran commented on issue #1754: HADOOP-16751: DurationInfo text parsing/formatting should be moved out of hotpath URL: https://github.com/apache/hadoop/pull/1754#issuecomment-570269771 I see. and reviewing it, yes, that `getFormattedText()` does update the cached value. +1

[GitHub] [hadoop] steveloughran commented on issue #1754: HADOOP-16751: DurationInfo text parsing/formatting should be moved out of hotpath

2019-12-11 Thread GitBox
steveloughran commented on issue #1754: HADOOP-16751: DurationInfo text parsing/formatting should be moved out of hotpath URL: https://github.com/apache/hadoop/pull/1754#issuecomment-564592805 well spotted perf issue. The patch is doing lazy eval, but it now does it in: start, finish