[GitHub] [hadoop] steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8

2019-06-19 Thread GitBox
steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8 URL: https://github.com/apache/hadoop/pull/970#issuecomment-503498567 > (did not have S3Guard or kms tests setup) You are going to have to do S3Guard tests here beca

[GitHub] [hadoop] steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8

2019-08-09 Thread GitBox
steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8 URL: https://github.com/apache/hadoop/pull/970#issuecomment-519885574 @sahilTakiar I've left some comments. it'd be good for @DadanielZ to review too ---

[GitHub] [hadoop] steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8

2019-09-11 Thread GitBox
steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8 URL: https://github.com/apache/hadoop/pull/970#issuecomment-530306812 thanks for updating this. Was this just a rebase + push or have you made other changes? -

[GitHub] [hadoop] steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8

2019-09-16 Thread GitBox
steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8 URL: https://github.com/apache/hadoop/pull/970#issuecomment-531754074 Patch is coming together nicely -nearly there. Done CLI tests as well as the -aws suite, A

[GitHub] [hadoop] steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8

2019-09-16 Thread GitBox
steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8 URL: https://github.com/apache/hadoop/pull/970#issuecomment-531803157 Did a full test run `-Ds3guard -Ddynamodb -Dscale -Dauth`; all failures DDB table delete timeouts and

[GitHub] [hadoop] steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8

2019-09-17 Thread GitBox
steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8 URL: https://github.com/apache/hadoop/pull/970#issuecomment-532157254 > the only additional failure is ITestS3AFileOperationCost, which is failing on trunk for me as well.

[GitHub] [hadoop] steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8

2019-09-17 Thread GitBox
steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8 URL: https://github.com/apache/hadoop/pull/970#issuecomment-532163271 thanks for the final revision and explanation of why classloading wasn't going to be a problem