[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-06-10 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-642142997 aah, i need to rebase. @mehakmeet -this is going to complicate your life. sorry. I'll do a whole new PR. having written the new extensible design, I've decided I don'

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-06-09 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-641182474 checkstyle. I intend to ignore those about _1, _2 and _3 methods as they match scala's; I plan to soon add tuple/triple classes with these to hadoop utils ---

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-05-18 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-630284411 This patch adds LocalFS/RawLocalFS/ChecksummedFileSystem statistics passthrough and collection. Getting everything passed through is actually the harder part of the

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-05-14 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-628616574 add methods to add two iostatistics instances, and to subtract one from the other. This will help merging stats from multiple file read/writes, and for when we add the API

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-05-07 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-625397876 cannot repeat this was an eight thread parallel run, maybe there was some retry/timeout This is an automat

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-05-07 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-625240548 failure on a test run, which is related to stats gathering. But I don't see this when run from the IDE. Race condition? ``` [ERROR] ITestCommitOperations.testBu

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-05-06 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-624658465 > How can I add a counter of type **long** through the builder? it takes any lambda expression, so you can go add(key, (key) ->this.getLongval()). Having so

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-04-27 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-620220105 Successor to #1820. regarding AWS metric failures, when enabled code which goes near landat and common crawl buckets are failing, even when the default endpoint is b