[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-09-21 Thread GitBox
steveloughran commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-696286408 Closing this; best to rebuild as a new PR atop trunk. For the next PR I plan to split into * hadoop-common * hadoop-aws trickier than I'd like, but, it

[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-09-21 Thread GitBox
steveloughran commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-696286408 Closing this; best to rebuild as a new PR atop trunk. For the next PR I plan to split into * hadoop-common * hadoop-aws trickier than I'd like, but, it

[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-09-04 Thread GitBox
steveloughran commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-687247574 OK, despite my force push losing @jimmy-zuber-amzn 's comments, I agree with the points about thread safety. In my head I'd imagined that we'd build that implementation

[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-08-25 Thread GitBox
steveloughran commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-680292512 ...no, I haven't reviewed anyone elses work today, just been rebasing and wiring up the marker and async listing changes. To put them both together, the "s3guard

[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-08-07 Thread GitBox
steveloughran commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-670536132 FFS. I slightly expand the synchronization of MeanStatistic and now findbugs gets even more upset than before. I'm going to declare all as sync even though it will hurt

[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-08-06 Thread GitBox
steveloughran commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-670090916 Test `TestLocalFileSystem` failure happens as the new "BufferedIOStatisticsOutputStream" class rejects calls to Syncable APIs if the wrapped class doesn't support it. This

[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-07-20 Thread GitBox
steveloughran commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-661077889 The latest update records the min/max and mean times to initiate the (long-haul) http get request ``` 2020-07-17 17:56:30,433 [JUnit] INFO  

[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-07-03 Thread GitBox
steveloughran commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-653619415 latest patch wires up stats collection from the workers on an s3a committer job, marshalls them as json in .pending/.pendingset files and then finally aggregates them into