[GitHub] [hadoop] steveloughran commented on pull request #2206: HADOOP-17038 Support positional read in AbfsInputStream

2020-10-07 Thread GitBox
steveloughran commented on pull request #2206: URL: https://github.com/apache/hadoop/pull/2206#issuecomment-704911520 why the close? I know it didn't quite work as is, but we should see what could be lifted/merged, in particular: tests -

[GitHub] [hadoop] steveloughran commented on pull request #2206: HADOOP-17038 Support positional read in AbfsInputStream

2020-09-03 Thread GitBox
steveloughran commented on pull request #2206: URL: https://github.com/apache/hadoop/pull/2206#issuecomment-686672349 > The Keys for the FSBuilder APIs needs to be generic. Any pointer where we need to add this? May be already we have a place for this with sample keys .. Wanted to see the

[GitHub] [hadoop] steveloughran commented on pull request #2206: HADOOP-17038 Support positional read in AbfsInputStream

2020-08-22 Thread GitBox
steveloughran commented on pull request #2206: URL: https://github.com/apache/hadoop/pull/2206#issuecomment-678664596 As discussed, I don't like this design. It's optimised purely for the current API uses which HBase makes, is brittle to any changes there and doesn't provide any way