[GitHub] [hadoop] steveloughran commented on pull request #2264: HADOOP-17229. No updation of bytes received counter value after response failure occurs in ABFS

2020-09-08 Thread GitBox
steveloughran commented on pull request #2264: URL: https://github.com/apache/hadoop/pull/2264#issuecomment-688736659 +1, merged to trunk, do a retest on branch-3.3 and I'll merge there too This is an automated message from t

[GitHub] [hadoop] steveloughran commented on pull request #2264: HADOOP-17229. No updation of bytes received counter value after response failure occurs in ABFS

2020-09-03 Thread GitBox
steveloughran commented on pull request #2264: URL: https://github.com/apache/hadoop/pull/2264#issuecomment-686653695 This is better. These are the only two responses which constitute success, right? This is an automated me

[GitHub] [hadoop] steveloughran commented on pull request #2264: HADOOP-17229. No updation of bytes received counter value after response failure occurs in ABFS

2020-09-02 Thread GitBox
steveloughran commented on pull request #2264: URL: https://github.com/apache/hadoop/pull/2264#issuecomment-685699945 LGTM, one minor change which is only count 200 responses, so as to make clear it is only successful GETs which are measured ---