steveloughran commented on pull request #2396:
URL: https://github.com/apache/hadoop/pull/2396#issuecomment-733737440
thanks -merging to 3.3+!
This is an automated message from the Apache Git Service.
To respond to the
steveloughran commented on pull request #2396:
URL: https://github.com/apache/hadoop/pull/2396#issuecomment-732967168
@surendralilhore -could you look @ this again? Think I've tried to address
your comments
This is an
steveloughran commented on pull request #2396:
URL: https://github.com/apache/hadoop/pull/2396#issuecomment-730426946
Don't get the test failure. Will rebase
```
[ERROR]
testServerKeyPasswordDefaultsToPassword(org.apache.hadoop.security.ssl.TestSSLFactory)
Time elapsed: 0.103 s
steveloughran commented on pull request #2396:
URL: https://github.com/apache/hadoop/pull/2396#issuecomment-718893014
> Is there particular reasoning for "64" as the default value?
No. I wondered whether to make it smaller or just leave large.
Large: no visible impact of this
steveloughran commented on pull request #2396:
URL: https://github.com/apache/hadoop/pull/2396#issuecomment-718889722
```
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:3512:
checkArgument(permits > 0 , "Invalid value of %s: %s",:33: ','
steveloughran commented on pull request #2396:
URL: https://github.com/apache/hadoop/pull/2396#issuecomment-713581331
Also, I plan to move the close in a discard out of the locked area. It's not
needed and an FS is doing anything there, we don't want to block the other
threads
steveloughran commented on pull request #2396:
URL: https://github.com/apache/hadoop/pull/2396#issuecomment-713560550
yeah, let me get that out the way before I forget about that cache. I'll use
a counter of discarded instances and test off that. I'll plan some tricks to
avoid the test
steveloughran commented on pull request #2396:
URL: https://github.com/apache/hadoop/pull/2396#issuecomment-712293705
For interest of @snvijaya @rajeshbalamohan @mukund-thakur @mehakmeet
Not thought of a good test yet, at least not one overly destructive.
Probably
* private
