steveloughran commented on pull request #2510: URL: https://github.com/apache/hadoop/pull/2510#issuecomment-743758868
FWIW that checkArgument(varags) does exist in older versions; what's gone wrong is that google added specific overloads for certain non-varargs variant, e.g (String, int) so that stuff built against the newer version isn't going to link. Adding a String.format does make that arg checking a bit more expensive, as it's being calculated even on the correct sequence. We are moving to our own precondition checker because of the guava pain; we should switch to that ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
