[GitHub] [hadoop] steveloughran commented on pull request #2545: HADOOP-17430. Add clear bytes logic for hadoop Text

2020-12-13 Thread GitBox
steveloughran commented on pull request #2545: URL: https://github.com/apache/hadoop/pull/2545#issuecomment-744003658 Hey, no need to close the #2544 PR. It's only an issue if the PR needs rebasing and there's been lots of reviewing on patches -the rebase loses the history. Somethin

[GitHub] [hadoop] steveloughran commented on pull request #2545: HADOOP-17430. Add clear bytes logic for hadoop Text

2021-01-05 Thread GitBox
steveloughran commented on pull request #2545: URL: https://github.com/apache/hadoop/pull/2545#issuecomment-754899716 Javadocs look good, and test failures are the OOM problems we've started having. +1, merging to trunk and backporting to 3.3. Thanks! --

[GitHub] [hadoop] steveloughran commented on pull request #2545: HADOOP-17430. Add clear bytes logic for hadoop Text

2021-01-08 Thread GitBox
steveloughran commented on pull request #2545: URL: https://github.com/apache/hadoop/pull/2545#issuecomment-756690095 sorry, was my cherrypick which broke it. reverted This is an automated message from the Apache Git Service.

[GitHub] [hadoop] steveloughran commented on pull request #2545: HADOOP-17430. Add clear bytes logic for hadoop Text

2021-01-09 Thread GitBox
steveloughran commented on pull request #2545: URL: https://github.com/apache/hadoop/pull/2545#issuecomment-756690095 sorry, was my cherrypick which broke it. reverted This is an automated message from the Apache Git Service.