steveloughran commented on PR #4255:
URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1183115938
+cherrypicked to branch-3.3; ran new test suite and all is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
steveloughran commented on PR #4255:
URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1183110785
+1, merging. thank you for your diligence here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
steveloughran commented on PR #4255:
URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1141140899
the inode stuff has been fixed elsewhere. if you rebase or merge your pr, it
will go away. or we just ignore it, which simplifies keeping this commit
history/discussion valid
--
T
steveloughran commented on PR #4255:
URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1123496521
thanks for that detailed explanation.
you are right that spawning jvms and trying trigger timeouts would be
trouble. lets just rely on code review here.
atomic references so
steveloughran commented on PR #4255:
URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1116084353
checkstyle is complaining about line length. move the comments to the lines
above the source and all is good. we don't normally have comments of any kind
on the same lines as code
