[GitHub] [hadoop] steveloughran commented on pull request #5198: HADOOP-18546. Followup: ITestReadBufferManager fix

2022-12-13 Thread GitBox
steveloughran commented on PR #5198: URL: https://github.com/apache/hadoop/pull/5198#issuecomment-1348133141 yeah, nothing related to this pr. been mentioned elsewhere and i think it's java 11 related. moving to a static import of the specific values will apparently fix, but this should be

[GitHub] [hadoop] steveloughran commented on pull request #5198: HADOOP-18546. Followup: ITestReadBufferManager fix

2022-12-09 Thread GitBox
steveloughran commented on PR #5198: URL: https://github.com/apache/hadoop/pull/5198#issuecomment-1344327283 not happy about javadoc failures, but looks unrelated (annotation issues? javadoc changes?). going to approve this myself because it's only a test change, and the change is ju

[GitHub] [hadoop] steveloughran commented on pull request #5198: HADOOP-18546. Followup: ITestReadBufferManager fix

2022-12-09 Thread GitBox
steveloughran commented on PR #5198: URL: https://github.com/apache/hadoop/pull/5198#issuecomment-1344177793 ok, updated this one, which i'm using in my internal cherrypick which I need for e2e testing though spark. will review your #5199 change which does more than just comment out t

[GitHub] [hadoop] steveloughran commented on pull request #5198: HADOOP-18546. Followup: ITestReadBufferManager fix

2022-12-08 Thread GitBox
steveloughran commented on PR #5198: URL: https://github.com/apache/hadoop/pull/5198#issuecomment-1343222370 azure endpoint is cardiff; parallel -Dscale run in progress. already verified the failing test seems happy now. (given i've deleted assertions, it'd be hard not to -- This is an a