[GitHub] [hadoop] steveloughran commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-26 Thread via GitHub
steveloughran commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1694332800 no worries. when i saw it in the change log I was wondering if there was a CVE fix coming in -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] steveloughran commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-25 Thread via GitHub
steveloughran commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1693337002 final bit of credit; is `TIsNotT` your jira account id? as we need to credit you on jira too -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] steveloughran commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-25 Thread via GitHub
steveloughran commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1693329070 ...no need to do that; I have command line access too. updated. ``` HDFS-17162. RBF: Add missing comments in StateStoreService #5959 Contributed by tian bao ```

[GitHub] [hadoop] steveloughran commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-24 Thread via GitHub
steveloughran commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1691323455 hey, remember to include the JIRA ID in the commit title; when i first saw this in the commit message i thought it was a CVE fix going in. how about we revert and then