sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691323603
> @sunchao I think all tests are passed. But there are two -1, do you know
what it means?
@viirya looks like the gcc compilation or check style failed - you can check
test
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691335721
Yes. I also don't see any error in the log files. I think we can check
[Yetus](https://github.com/apache/yetus) repo to see how it decides whether it
is a -1 or -0.
cc @j
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691337075
BTW I think we no longer need the `-Drequire.snappy` flag and
`REQUIRE_SNAPPY` anymore with this right?
This is
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691323603
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691323603
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691323603
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691729909
> So I am not sure which one is good, fixing these compilation warnings, or
ignoring them?
Yeah. Looks to me we can just ignore these for now and proceed to other
things i
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691875174
Just re-triggered the job let's see what happens
This is an automated message from the Apache Git Service.
To res
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-692174719
@viirya interesting ... I think you can send an email to the Hadoop dev list
(`common-...@hadoop.apache.org`, you may need to subscribe first).
-
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-699097890
(nit nit) we may need to update [NativeLibraries
guide](https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/site/markdown/NativeLibraries.md.vm)
a
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-700927518
> bad: doesn't work so well if things (hadoop-client?) shade the snappy jar
references.
Since this dependency is new, as long we make sure it is not shaded in the
client m
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-702900335
The style issue was fixed in the last run. The CI failed because of [unit
tests](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/20/testReport/)
and [ASF
license
sunchao commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-705055574
Thanks @steveloughran - could you assign the JIRA to @viirya ?
This is an automated message from the Apache Git
13 matches
Mail list logo
