[GitHub] [hadoop] tamaashu commented on issue #1730: HADOOP-16729. Extract version numbers to head of pom.xml

2019-11-27 Thread GitBox
tamaashu commented on issue #1730: HADOOP-16729. Extract version numbers to head of pom.xml URL: https://github.com/apache/hadoop/pull/1730#issuecomment-559087752 PR for branch 3.2: https://github.com/apache/hadoop/pull/1732

[GitHub] [hadoop] tamaashu commented on issue #1730: HADOOP-16729. Extract version numbers to head of pom.xml

2019-11-27 Thread GitBox
tamaashu commented on issue #1730: HADOOP-16729. Extract version numbers to head of pom.xml URL: https://github.com/apache/hadoop/pull/1730#issuecomment-559081935 @adamantal done > It might make sense to put the log4j version right after the slf4j one a bit above, but it's perfectly oka

[GitHub] [hadoop] tamaashu commented on issue #1730: HADOOP-16729. Extract version numbers to head of pom.xml

2019-11-27 Thread GitBox
tamaashu commented on issue #1730: HADOOP-16729. Extract version numbers to head of pom.xml URL: https://github.com/apache/hadoop/pull/1730#issuecomment-559042604 There is no need for additional or modified tests since, I didn't change any code. The only change is that I define third parti