tomicooler opened a new pull request, #5644: URL: https://github.com/apache/hadoop/pull/5644
### Description of PR YARN-11211 broke the JMX QueueMetrics, detailed root cause analysis in the [Jira](https://issues.apache.org/jira/browse/YARN-11490?focusedCommentId=17721370&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17721370). ### How was this patch tested? ```shell # run a long sleep job hadoop-3.4.0-SNAPSHOT/bin/yarn jar hadoop-3.4.0-SNAPSHOT/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-3.4.0-SNAPSHOT-tests.jar sleep -m 1 -r 1 -rt 1200000 -mt 20 # tried to validate an add-queue operation curl -X POST -H 'Content-Type: application/xml' -d @addqueue.xml localhost:8088/ws/v1/cluster/scheduler-conf/validate # verified that no root.a is in the jmx response curl http://localhost:8088/jmx | jq # validated a queue config change curl -X POST -H 'Content-Type: application/json' -d @defaultqueue.json localhost:8088/ws/v1/cluster/scheduler-conf/validate # submitted other jobs # repeated these steps multiple times and verified that the jmx endpoint still shows valid data (e.g.: appsRunning/appsPending works, there is no root.a in the response) # created the root.a queue curl -X PUT -H 'Content-Type: application/xml' -d @removequeue.xml localhost:8088/ws/v1/cluster/scheduler-conf # verified that the jmx response contains the root.a (2x times: "QueueMetrics,q0=root,q1=a" and "PartitionQueueMetrics,partition=,q0=root,q1=a") curl http://localhost:8088/jmx | jq ``` ```shell # restarted yarn, then I created the root.a queue, and compared the jmx response to the previous test curl -X PUT -H 'Content-Type: application/xml' -d @removequeue.xml localhost:8088/ws/v1/cluster/scheduler-conf curl http://localhost:8088/jmx | jq ``` Note: based on my understanding of the code `PartitionQueueMetrics` can't show the appsRunning/appsPending (at least not for the CapacityScheduler). ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
