[GitHub] [hadoop] tomscut commented on pull request #2676: Make some parameters configurable for DataNodeDiskMetrics

2021-02-09 Thread GitBox
tomscut commented on pull request #2676: URL: https://github.com/apache/hadoop/pull/2676#issuecomment-776398915 > The change looks pretty good to me. Please file an Apache jira. > > The failed tests look unrelated to your change. Thank you for your review! This is the Ap

[GitHub] [hadoop] tomscut commented on pull request #2676: Make some parameters configurable for DataNodeDiskMetrics

2021-02-08 Thread GitBox
tomscut commented on pull request #2676: URL: https://github.com/apache/hadoop/pull/2676#issuecomment-775602310 @hanishakoneru Hi Hanisha Koneru, could you please review the code for me? Thanks! This is an automated messa

[GitHub] [hadoop] tomscut commented on pull request #2676: Make some parameters configurable for DataNodeDiskMetrics

2021-02-03 Thread GitBox
tomscut commented on pull request #2676: URL: https://github.com/apache/hadoop/pull/2676#issuecomment-772976198 Failed junit tests: hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes hadoop.hdfs.TestReconstr