[GitHub] [hadoop] tomscut commented on pull request #3635: HDFS-16310. RBF: Add client port to CallerContext for Router

2021-11-17 Thread GitBox
tomscut commented on pull request #3635: URL: https://github.com/apache/hadoop/pull/3635#issuecomment-972550909 Thanks @tasanuma for your comment and the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] tomscut commented on pull request #3635: HDFS-16310. RBF: Add client port to CallerContext for Router

2021-11-17 Thread GitBox
tomscut commented on pull request #3635: URL: https://github.com/apache/hadoop/pull/3635#issuecomment-971522587 > @tomscut With the latest commit, it seems Router adds a client port even if `dfs.namenode.audit.log.with.remote.port=false`. We may want to add a client port only when `dfs.nam

[GitHub] [hadoop] tomscut commented on pull request #3635: HDFS-16310. RBF: Add client port to CallerContext for Router

2021-11-16 Thread GitBox
tomscut commented on pull request #3635: URL: https://github.com/apache/hadoop/pull/3635#issuecomment-971026573 Hi @tasanuma @jojochuang @ferhui @ayushtkn , could you please take a look at this. Thank you very much. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] tomscut commented on pull request #3635: HDFS-16310. RBF: Add client port to CallerContext for Router

2021-11-16 Thread GitBox
tomscut commented on pull request #3635: URL: https://github.com/apache/hadoop/pull/3635#issuecomment-971023970 > There's a failure with TestRouterDistCpProcedure but I don't see how it can be related. Can you confirm? Thank @goiri for your review. This failed unit test is unrelated