[GitHub] [hadoop] tomscut commented on pull request #3828: HDFS-16397. Reconfig slow disk parameters for datanode

2022-02-24 Thread GitBox
tomscut commented on pull request #3828: URL: https://github.com/apache/hadoop/pull/3828#issuecomment-1050392857 Thanks @tasanuma for reviewing and merging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] tomscut commented on pull request #3828: HDFS-16397. Reconfig slow disk parameters for datanode

2022-02-24 Thread GitBox
tomscut commented on pull request #3828: URL: https://github.com/apache/hadoop/pull/3828#issuecomment-1049765538 https://user-images.githubusercontent.com/55134131/155515733-fda10a2c-19fd-4817-8a25-ca27761ddafe.png;> Hi @tasanuma those failed unit tests seem related to OOM. Do I need

[GitHub] [hadoop] tomscut commented on pull request #3828: HDFS-16397. Reconfig slow disk parameters for datanode

2022-02-24 Thread GitBox
tomscut commented on pull request #3828: URL: https://github.com/apache/hadoop/pull/3828#issuecomment-1049629967 It looks like there are some errors. Let me retrigger it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] tomscut commented on pull request #3828: HDFS-16397. Reconfig slow disk parameters for datanode

2022-02-23 Thread GitBox
tomscut commented on pull request #3828: URL: https://github.com/apache/hadoop/pull/3828#issuecomment-1049417921 > @tomscut Sorry for being late, and thanks for working on this. It mostly looks good to me. I left some minor comments. Thank you @tasanuma very much for your review and

[GitHub] [hadoop] tomscut commented on pull request #3828: HDFS-16397. Reconfig slow disk parameters for datanode

2022-02-17 Thread GitBox
tomscut commented on pull request #3828: URL: https://github.com/apache/hadoop/pull/3828#issuecomment-1044072245 This feature is similar to [HDFS-16396. Reconfig slow peer parameters for datanode](https://issues.apache.org/jira/browse/HDFS-16396). -- This is an automated message

[GitHub] [hadoop] tomscut commented on pull request #3828: HDFS-16397. Reconfig slow disk parameters for datanode

2022-02-17 Thread GitBox
tomscut commented on pull request #3828: URL: https://github.com/apache/hadoop/pull/3828#issuecomment-1043965231 Hi @tasanuma @ayushtkn @jojochuang @Hexiaoqiao , could you please review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] tomscut commented on pull request #3828: HDFS-16397. Reconfig slow disk parameters for datanode

2022-02-15 Thread GitBox
tomscut commented on pull request #3828: URL: https://github.com/apache/hadoop/pull/3828#issuecomment-1040929250 Hi @tasanuma @ayushtkn @Hexiaoqiao , could you please review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please