[GitHub] [hadoop] umamaheswararao commented on pull request #5738: HDFS-17045. File renamed from a snapshottable dir to a non-snapshottable dir cannot be deleted.

2023-06-14 Thread via GitHub
umamaheswararao commented on PR #5738: URL: https://github.com/apache/hadoop/pull/5738#issuecomment-1590615079 +1 Patch looks good to me. Pending CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] umamaheswararao commented on pull request #5738: HDFS-17045. File renamed from a snapshottable dir to a non-snapshottable dir cannot be deleted.

2023-06-13 Thread via GitHub
umamaheswararao commented on PR #5738: URL: https://github.com/apache/hadoop/pull/5738#issuecomment-1590341301 Can we add similar test for the case where rename happens within the snapshot directory and make sure quotas are ok? I just tried and it worked though. It would be good to have