viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691179411
@dbtsai Yeah, let me look at it today. Hope to pass all tests soon.
This is an automated message from the Apache G
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691322819
@sunchao I think all tests are passed. But there are two -1, do you know
what it means?
This is an automated mess
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691328677
@sunchao Thanks. I saw a check style failure:
```
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/snappy/TestSnappyCompressorDecompresso
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691330003
And I think for checkstyle, it is just a -0? For two cc links, I don't see
any errors:
cc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/d
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691338456
> BTW I think we no longer need the `-Drequire.snappy` flag and
`REQUIRE_SNAPPY` anymore with this right?
Yes, I plan to remove them once we get rid of -1.
---
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691179411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691179411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691179411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691712861
Checked the cc warnings and the related code. They are code long time ago,
e.g., 2014, and not touched here. Many of the cc warnings are `warning: dynamic
exception specifications
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691820247
Looks like CI failed to fetch and install yetus? @sunchao do you know how we
can re-trigger CI build and testing?
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-692157442
It seems still failed to fetch and install yetus, and not just this PR,
other PRs also encountered it...
This is
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-692167279
@sunchao Who we should let them know about the CI issue?
This is an automated message from the Apache Git Service.
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-692897475
OK, seems the CI is working now.
This is an automated message from the Apache Git Service.
To respond to the messa
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-692909328
I have run a benchmark and compatibility test locally. I use SnappyCodec to
write and read a ~200MB SequenceFile. Before and after this change, the
performance is nearly the same.
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-694659679
Regarding the change of mvn dependency.
For Apache Hadoop Common, the diff is:
Before:
```
[INFO] +- org.apache.avro:avro:jar:1.7.7:compile
[INFO] | +- com.t
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-698516626
@saintstack @steveloughran Thanks for the reviews. I think I addressed the
latest comments.
This is an automated
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-698516626
@saintstack @steveloughran Thanks for the reviews. I think I addressed the
latest comments.
This is an automated
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-699039044
@saintstack @steveloughran Is this change looking good for you now? Based on
this change, we will work on the compression module per
https://github.com/apache/hadoop/pull/2159#iss
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-699115827
Thanks @sunchao for review. Addressed your comments.
This is an automated message from the Apache Git Service.
To
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-701041484
@sunchao Thanks for review. I addressed your comments. Please let me know if
you have more comments.
This is an a
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-702273856
Hmm, for CompressDecompressTester.java, it seems to me that it is from
original code?
```java
else if (compressor.getClass().isAssignableFrom(ZlibCompressor.class)) {
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-702933677
Fixed another and last style issue. Checked with `mvn checkstyle:check`
locally.
This is an automated message fro
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-703801190
Thanks @steveloughran and @saintstack. Updated the diff based on your
suggestions.
This is an automated message f
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-704394123
Thanks @steveloughran @saintstack @sunchao @dbtsai
This is an automated message from the Apache Git Service.
To r
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-704433770
Ok, got it. I will update release notes once it is back.
This is an automated message from the Apache Git Service.
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-704434440
Looks like the JIRA is back now?
https://issues.apache.org/jira/browse/HADOOP-17125
This is an automated message
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-706292851
@steveloughran Username is viirya too. Thanks.
This is an automated message from the Apache Git Service.
To respon
viirya commented on pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#issuecomment-707207886
@steveloughran Thank you! I tried to assign this ticket, but seems cannot do
it.
This is an automated message fro
28 matches
Mail list logo
