[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113789406 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113770486 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113830663 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/AsyncRFAAppender.java: ## @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Software

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113830663 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/AsyncRFAAppender.java: ## @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Software

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113789406 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113759661 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113779366 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113759661 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113770486 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113758871 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java: ## @@ -115,8 +111,11 @@ private String trimLine(String