[GitHub] [hadoop] virajjasani commented on a diff in pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-05-22 Thread via GitHub
virajjasani commented on code in PR #5503: URL: https://github.com/apache/hadoop/pull/5503#discussion_r1200771313 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java: ## @@ -220,27 +219,21 @@ public void testFinalWarnings() throws

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-05-21 Thread via GitHub
virajjasani commented on code in PR #5503: URL: https://github.com/apache/hadoop/pull/5503#discussion_r1199923215 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -349,7 +348,7 @@ public void doGet(HttpServletRequest request,

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-05-21 Thread via GitHub
virajjasani commented on code in PR #5503: URL: https://github.com/apache/hadoop/pull/5503#discussion_r1199921484 ## hadoop-common-project/hadoop-common/src/main/conf/log4j.properties: ## @@ -299,7 +299,7 @@ log4j.appender.NMAUDIT.MaxBackupIndex=${nm.audit.log.maxbackupindex}