[GitHub] [hadoop] virajjasani commented on a diff in pull request #5718: HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag

2023-06-13 Thread via GitHub
virajjasani commented on code in PR #5718: URL: https://github.com/apache/hadoop/pull/5718#discussion_r1228809990 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -333,37 +335,31 @@ protected Path getCach

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5718: HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag

2023-06-12 Thread via GitHub
virajjasani commented on code in PR #5718: URL: https://github.com/apache/hadoop/pull/5718#discussion_r1226902160 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -333,37 +335,31 @@ protected Path getCach

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5718: HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag

2023-06-12 Thread via GitHub
virajjasani commented on code in PR #5718: URL: https://github.com/apache/hadoop/pull/5718#discussion_r1226902160 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -333,37 +335,31 @@ protected Path getCach

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5718: HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag

2023-06-12 Thread via GitHub
virajjasani commented on code in PR #5718: URL: https://github.com/apache/hadoop/pull/5718#discussion_r1226851855 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -333,37 +335,31 @@ protected Path getCach

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5718: HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag

2023-06-08 Thread via GitHub
virajjasani commented on code in PR #5718: URL: https://github.com/apache/hadoop/pull/5718#discussion_r1223347046 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -333,37 +335,33 @@ protected Path getCach