[GitHub] [hadoop] virajjasani commented on pull request #2985: HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets

2021-05-07 Thread GitBox
virajjasani commented on pull request #2985: URL: https://github.com/apache/hadoop/pull/2985#issuecomment-834130321 @aajisaka If you would like to take a look while QA is in progress (QA here is full build, hence will take 17+ hr for sure). -- This is an automated message from the Apache

[GitHub] [hadoop] virajjasani commented on pull request #2985: HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets

2021-05-08 Thread GitBox
virajjasani commented on pull request #2985: URL: https://github.com/apache/hadoop/pull/2985#issuecomment-835327152 So far only one build was able to successfully post QA results back to PR, rest have been aborted (I think it is expected when full build is run). However, I have taken scr

[GitHub] [hadoop] virajjasani commented on pull request #2985: HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets

2021-05-10 Thread GitBox
virajjasani commented on pull request #2985: URL: https://github.com/apache/hadoop/pull/2985#issuecomment-837023391 @busbey There is one problem here though. Adding `maven-enforcer-plugin` to ban imports is somehow not working at top level module (e.g `hadoop-common-project`), it works onl

[GitHub] [hadoop] virajjasani commented on pull request #2985: HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets in hadoop-common and hadoop-tools

2021-05-10 Thread GitBox
virajjasani commented on pull request #2985: URL: https://github.com/apache/hadoop/pull/2985#issuecomment-837060377 > However, since you already got an idea of what wrappers need to be implemented to replace the {{Guava.sets}}, it may be better to create a PR only for the wrappers (includi

[GitHub] [hadoop] virajjasani commented on pull request #2985: HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets in hadoop-common and hadoop-tools

2021-05-10 Thread GitBox
virajjasani commented on pull request #2985: URL: https://github.com/apache/hadoop/pull/2985#issuecomment-837175796 > Describe the failure? Is it not complaining when a banned import is present? That's correct. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [hadoop] virajjasani commented on pull request #2985: HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets in hadoop-common and hadoop-tools

2021-05-12 Thread GitBox
virajjasani commented on pull request #2985: URL: https://github.com/apache/hadoop/pull/2985#issuecomment-839956955 @busbey I guess we can't do much about this Javac warning: ``` hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Sets.java:80:47:[unchecked] Poss

[GitHub] [hadoop] virajjasani commented on pull request #2985: HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets in hadoop-common and hadoop-tools

2021-05-18 Thread GitBox
virajjasani commented on pull request #2985: URL: https://github.com/apache/hadoop/pull/2985#issuecomment-843189446 Thanks @busbey, let me squash all commits into single one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an