[GitHub] [hadoop] virajjasani commented on pull request #3362: HDFS-16199. Resolve log placeholders in NamenodeBeanMetrics

2021-09-03 Thread GitBox
virajjasani commented on pull request #3362: URL: https://github.com/apache/hadoop/pull/3362#issuecomment-912527131 > It is debug log, Can we not just pass e as whole, rather than just printing the message, The trace might be more helpful while debugging? Nothing wrong with that, the

[GitHub] [hadoop] virajjasani commented on pull request #3362: HDFS-16199. Resolve log placeholders in NamenodeBeanMetrics

2021-09-03 Thread GitBox
virajjasani commented on pull request #3362: URL: https://github.com/apache/hadoop/pull/3362#issuecomment-912323906 FYI @aajisaka, Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [hadoop] virajjasani commented on pull request #3362: HDFS-16199. Resolve log placeholders in NamenodeBeanMetrics

2021-09-02 Thread GitBox
virajjasani commented on pull request #3362: URL: https://github.com/apache/hadoop/pull/3362#issuecomment-911492004 Thanks for the reviews @goiri @tomscut ! Could you please help merge the PR @goiri? Thanks -- This is an automated message from the Apache Git Service. To respond to the