[GitHub] [hadoop] virajjasani commented on pull request #5385: HADOOP-18628. Server connection should log host name before returning VersionMismatch error

2023-02-17 Thread via GitHub
virajjasani commented on PR #5385: URL: https://github.com/apache/hadoop/pull/5385#issuecomment-1434958099 Thanks Steve, PR to fix the audit log format https://github.com/apache/hadoop/pull/5407 The change for audit log in PR #5407 works with or without this PR changes as we no longer wa

[GitHub] [hadoop] virajjasani commented on pull request #5385: HADOOP-18628. Server connection should log host name before returning VersionMismatch error

2023-02-16 Thread via GitHub
virajjasani commented on PR #5385: URL: https://github.com/apache/hadoop/pull/5385#issuecomment-1433622305 > https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Compatibility.html#Audit_Log_Output I see, thanks for sharing this. Interesting, I am not sure if this

[GitHub] [hadoop] virajjasani commented on pull request #5385: HADOOP-18628. Server connection should log host name before returning VersionMismatch error

2023-02-15 Thread via GitHub
virajjasani commented on PR #5385: URL: https://github.com/apache/hadoop/pull/5385#issuecomment-1431997273 Since the tests run were limited to hadoop-common for this PR, hdfs tests were not run. Please review regex fix required after this change for hdfs audit log tests: https://github.c

[GitHub] [hadoop] virajjasani commented on pull request #5385: HADOOP-18628. Server connection should log host name before returning VersionMismatch error

2023-02-14 Thread via GitHub
virajjasani commented on PR #5385: URL: https://github.com/apache/hadoop/pull/5385#issuecomment-1430362627 Thanks for the reviews! branch-3.3 backport PR: https://github.com/apache/hadoop/pull/5395 -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hadoop] virajjasani commented on pull request #5385: HADOOP-18628. Server connection should log host name before returning VersionMismatch error

2023-02-11 Thread via GitHub
virajjasani commented on PR #5385: URL: https://github.com/apache/hadoop/pull/5385#issuecomment-1426957655 @ayushtkn @tomscut Could you please also review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop] virajjasani commented on pull request #5385: HADOOP-18628. Server connection should log host name before returning VersionMismatch error

2023-02-11 Thread via GitHub
virajjasani commented on PR #5385: URL: https://github.com/apache/hadoop/pull/5385#issuecomment-1426873755 @jojochuang @cnauroth @steveloughran Could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a