vnhive commented on pull request #3966:
URL: https://github.com/apache/hadoop/pull/3966#issuecomment-1059053952
- @aajisaka @jojochuang
- I have seen the following Unit Test Failure. I am presenting a quick
analysis. There will be some delay in addressing them, since I have switched to
vnhive commented on pull request #3966:
URL: https://github.com/apache/hadoop/pull/3966#issuecomment-1059050684
> Hi @vnhive - Thank you for the PR!
>
> There are some checkstyle issues to be fixed:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3966/5/artifact/out/result
vnhive commented on pull request #3966:
URL: https://github.com/apache/hadoop/pull/3966#issuecomment-1055331375
@jojochuang I have raised a new pull request with the following changes
Adding support for reading ssl configuration from ssl-server.xml and
ssl-client.xml. This unifies
vnhive commented on pull request #3966:
URL: https://github.com/apache/hadoop/pull/3966#issuecomment-1055000899
@jojochuang Thank you very much for your earlier comments. I am working on
the refactoring the test code. If you had more comments on the changes in
Server.java and Client.java,
vnhive commented on pull request #3966:
URL: https://github.com/apache/hadoop/pull/3966#issuecomment-1046591662
@jojochuang
Thank you very much for the quick review of the patch.
I have been working on the unit tests and found that when I ran the SSL
tests, after disabling t
vnhive commented on pull request #3966:
URL: https://github.com/apache/hadoop/pull/3966#issuecomment-1041043255
> Some quick comments. I haven't gone through the netty code yet.
Thanks a ton for the quick review and reply.
I have updated the latest patch addressing the comments
