[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006314263 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -997,6 +1008,20 @@ public T invokeSeque

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006313820 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -734,6 +806,11 @@ public boolean mk

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006260919 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -734,6 +806,11 @@ public boolean mk

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006245564 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -144,6 +145,95 @@ private boolean addMou

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006029768 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,78 @@ public boolean de

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006017718 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -144,6 +145,95 @@ private boolean addMou

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003631842 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,49 @@ public boolean de

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003605800 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,49 @@ public boolean de