[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-19 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1267885350 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java: ## @@ -17,26 +17,26 @@ */ package

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-19 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1267884190 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1926,12 +1926,41 @@ enum RenameStrategy {

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-19 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1267879273 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1266100987 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1266099967 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1926,12 +1926,41 @@ enum RenameStrategy {

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1266096591 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1926,12 +1926,41 @@ enum RenameStrategy {

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-16 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1264884503 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java: ## @@ -413,6 +413,11 @@ public T getTargetFileSystem() throws