[GitHub] [hadoop] zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-27 Thread GitBox
zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-546746842 @jojochuang @dineshchitlangia finally hadoop-yetus report `+1 overall`, can you please review and merge this PR.

[GitHub] [hadoop] zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-25 Thread GitBox
zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-546542548 @jojochuang I didn't get TestRollingUpgrade failed when I run it locally. Can you pls help to check is it a flaky test?

[GitHub] [hadoop] zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-24 Thread GitBox
zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-546139626 @jojochuang can you pls tell me how can I run the unittest locally, I see the jenkins job runs ``` /usr/bin/mvn

[GitHub] [hadoop] zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-23 Thread GitBox
zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545695573 This patch misses considering dir to dir overwrite scenario, will modify and push later, thx.

[GitHub] [hadoop] zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-23 Thread GitBox
zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545517326 @manojpec, please help to review this patch :) This is an