slfan1989 commented on code in PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#discussion_r1793739270
##
hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml:
##
@@ -154,10 +154,21 @@
provided
- com.sun.jersey.jersey-test-framework
- je
slfan1989 commented on code in PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#discussion_r1793735243
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java:
##
@@ -448,17 +443,15 @@ public List getGroups(String user) throws
IO
slfan1989 commented on code in PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#discussion_r1793730438
##
hadoop-common-project/hadoop-common/pom.xml:
##
@@ -93,104 +93,69 @@
compile
- javax.servlet
- javax.servlet-api
+ jakarta.servlet
slfan1989 commented on PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#issuecomment-2402636984
> > the overall renovation time has taken longer than expected
>
> I can't think of any big change where things took less than expected.
>
> I'll have a quick look at it, but
slfan1989 commented on PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#issuecomment-2402623880
@steveloughran
Thank you very much for reviewing this PR! Based on the recent compilation
results, we have largely resolved the unit test errors, sputbug, and
compilation issues
slfan1989 commented on PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#issuecomment-2380427389
I need your help to review this PR together. I know this PR contains many
changes. What else can I do to help you review it more effectively? Could you
give me some suggestions?
--
T
hadoop-yetus commented on PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#issuecomment-2380355237
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#issuecomment-2379596519
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#issuecomment-2375081319
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#issuecomment-2374817455
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
slfan1989 commented on PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#issuecomment-2370738063
@ayushtkn @aajisaka @virajjasani @steveloughran
I think we can start reviewing this PR now. Most issues have been resolved,
but there are indeed some problems that I will continue
slfan1989 commented on PR #6989:
URL: https://github.com/apache/hadoop/pull/6989#issuecomment-2283597443
@ayushtkn Thank you for your feedback! I will continue to improve this PR.
It might be because my current computer has an M3 chip, so it compiles
successfully. I will try compiling with
ayushtkn commented on PR #6989:
URL: https://github.com/apache/hadoop/pull/6989#issuecomment-2283585127
Some issue with the yetus I belive, need to investigate.
But It fails for me locally during compilation
```
[INFO] --- enforcer:3.0.0:enforce (depcheck) @ hadoop-yarn-common ---
hadoop-yetus commented on PR #6989:
URL: https://github.com/apache/hadoop/pull/6989#issuecomment-2283560846
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
slfan1989 commented on PR #6989:
URL: https://github.com/apache/hadoop/pull/6989#issuecomment-2283524997
@steveloughran @ayushtkn
I have good news: using Jersey 2.4.1, I can now compile it correctly on my
local machine. I’ve modified many unit tests, which also pass locally. Of
cour
hadoop-yetus commented on PR #6989:
URL: https://github.com/apache/hadoop/pull/6989#issuecomment-2283481882
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
slfan1989 closed pull request #6606: HADOOP-15984. Update jersey from 1.19 to
2.x
URL: https://github.com/apache/hadoop/pull/6606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1987044897
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1987036175
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1986996454
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1986962989
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1984948590
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1983367997
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1982178875
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1980575783
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1975123133
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6606:
URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1975084415
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
slfan1989 opened a new pull request, #6606:
URL: https://github.com/apache/hadoop/pull/6606
### Description of PR
JIRA: HADOOP-15984. Update jersey from 1.19 to 2.x
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts
28 matches
Mail list logo
