Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6466: URL: https://github.com/apache/hadoop/pull/6466#issuecomment-2078647702 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-02-09 Thread via GitHub
hadoop-yetus commented on PR #6466: URL: https://github.com/apache/hadoop/pull/6466#issuecomment-1936513805 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-02-09 Thread via GitHub
hadoop-yetus commented on PR #6466: URL: https://github.com/apache/hadoop/pull/6466#issuecomment-1936281849 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-02-09 Thread via GitHub
shintaroonuma commented on PR #6466: URL: https://github.com/apache/hadoop/pull/6466#issuecomment-1936098571 Thanks for the comments, rebased and updated the pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-02-09 Thread via GitHub
shintaroonuma commented on code in PR #6466: URL: https://github.com/apache/hadoop/pull/6466#discussion_r148513 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -82,6 +84,9 @@ public class DefaultS3ClientFactory extends

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-02-09 Thread via GitHub
shintaroonuma commented on code in PR #6466: URL: https://github.com/apache/hadoop/pull/6466#discussion_r148232 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -361,7 +366,15 @@ private static URI getS3Endpoint(String

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-01-30 Thread via GitHub
steveloughran commented on code in PR #6466: URL: https://github.com/apache/hadoop/pull/6466#discussion_r1471504240 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -82,6 +84,9 @@ public class DefaultS3ClientFactory extends

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-01-30 Thread via GitHub
steveloughran commented on code in PR #6466: URL: https://github.com/apache/hadoop/pull/6466#discussion_r1471473061 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -361,6 +366,13 @@ private static URI getS3Endpoint(String

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-01-26 Thread via GitHub
hadoop-yetus commented on PR #6466: URL: https://github.com/apache/hadoop/pull/6466#issuecomment-1912763510 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-01-26 Thread via GitHub
shintaroonuma commented on code in PR #6466: URL: https://github.com/apache/hadoop/pull/6466#discussion_r1467937565 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -361,6 +366,13 @@ private static URI getS3Endpoint(String

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-01-25 Thread via GitHub
steveloughran commented on code in PR #6466: URL: https://github.com/apache/hadoop/pull/6466#discussion_r1467048011 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -361,6 +366,13 @@ private static URI getS3Endpoint(String