Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
hadoop-yetus commented on PR #6292: URL: https://github.com/apache/hadoop/pull/6292#issuecomment-1923709399 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
steveloughran merged PR #6292: URL: https://github.com/apache/hadoop/pull/6292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
steveloughran commented on PR #6292: URL: https://github.com/apache/hadoop/pull/6292#issuecomment-1923651100 ... never mind, found your full name on the JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
steveloughran commented on PR #6292: URL: https://github.com/apache/hadoop/pull/6292#issuecomment-1923650431 @DieterDP-ng before I merge, what name do you want to be used in the commit message for credit? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
hadoop-yetus commented on PR #6292: URL: https://github.com/apache/hadoop/pull/6292#issuecomment-1923650369 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
steveloughran commented on code in PR #6292: URL: https://github.com/apache/hadoop/pull/6292#discussion_r1475955343 ## hadoop-common-project/hadoop-common/src/site/markdown/filesystem/abortable.md: ## @@ -87,15 +87,14 @@ for example. output streams returned by the S3A FileSystem

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
steveloughran commented on PR #6292: URL: https://github.com/apache/hadoop/pull/6292#issuecomment-1923640422 dieter, always best to not do a rebase and force push unless there's incompatible changes...makes it harder to see the diff. I know, I do it especially on long-lived PRs when other p

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
DieterDP-ng commented on code in PR #6292: URL: https://github.com/apache/hadoop/pull/6292#discussion_r1475786033 ## hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md: ## @@ -826,9 +826,9 @@ any successors. Postconditions -result = FSDa

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
DieterDP-ng commented on code in PR #6292: URL: https://github.com/apache/hadoop/pull/6292#discussion_r1475781381 ## hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md: ## @@ -432,7 +432,7 @@ of data which must be collected in a single RPC call. ##

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
DieterDP-ng commented on code in PR #6292: URL: https://github.com/apache/hadoop/pull/6292#discussion_r1475779161 ## hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md: ## @@ -88,7 +88,7 @@ Get the status of a path stat.length = len(FS.Fi

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2024-02-02 Thread via GitHub
DieterDP-ng commented on code in PR #6292: URL: https://github.com/apache/hadoop/pull/6292#discussion_r1475773739 ## hadoop-common-project/hadoop-common/src/site/markdown/filesystem/abortable.md: ## @@ -87,15 +87,14 @@ for example. output streams returned by the S3A FileSystem.

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2023-11-23 Thread via GitHub
steveloughran commented on code in PR #6292: URL: https://github.com/apache/hadoop/pull/6292#discussion_r1403319403 ## hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md: ## @@ -432,7 +432,7 @@ of data which must be collected in a single RPC call.

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6292: URL: https://github.com/apache/hadoop/pull/6292#issuecomment-1822864150 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2023-11-22 Thread via GitHub
DieterDP-ng opened a new pull request, #6292: URL: https://github.com/apache/hadoop/pull/6292 ### Description of PR This PR contains documentation updates to [the Hadoop FileSystem API definition](https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/filesystem/index