Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-17 Thread via GitHub
steveloughran merged PR #6441: URL: https://github.com/apache/hadoop/pull/6441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-17 Thread via GitHub
hadoop-yetus commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1896269981 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-17 Thread via GitHub
steveloughran commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1896063124 retested, all good except when I ran the openfile cost test with -Dprefetch, which was from #6425. Filed HADOOP-19043 for that -- This is an automated message from the Apache Git S

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-17 Thread via GitHub
steveloughran commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1895993631 need to rebase as the imports from the error handing pr conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-15 Thread via GitHub
steveloughran commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1892487074 build is failing from ``` [2024-01-15T14:27:46.923Z] Archiving artifacts No space left on device ``` this is nothing to do with this patch which has got through

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-15 Thread via GitHub
hadoop-yetus commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1892276379 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-12 Thread via GitHub
hadoop-yetus commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1889720957 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-12 Thread via GitHub
steveloughran commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1889514535 rebase problems; will submit fix. latest test runs works except for [HADOOP-19037](https://issues.apache.org/jira/browse/HADOOP-19037) _S3A: S3A: ITestS3AConfiguration failing with

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-11 Thread via GitHub
hadoop-yetus commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1887881094 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-11 Thread via GitHub
hadoop-yetus commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1887629876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-11 Thread via GitHub
hadoop-yetus commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1887607273 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-11 Thread via GitHub
hadoop-yetus commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1887602494 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-11 Thread via GitHub
HarshitGupta11 commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1887457133 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-11 Thread via GitHub
hadoop-yetus commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1887322151 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-11 Thread via GitHub
hadoop-yetus commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1887236208 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-11 Thread via GitHub
steveloughran commented on PR #6441: URL: https://github.com/apache/hadoop/pull/6441#issuecomment-1887191204 tested s3 london, all good. only failure is the one I see on trunk itself, `testEverything(org.apache.hadoop.fs.s3a.commit.ITestS3ACommitterFactory`. I should debug and fix th

[PR] HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false [hadoop]

2024-01-11 Thread via GitHub
steveloughran opened a new pull request, #6441: URL: https://github.com/apache/hadoop/pull/6441 HADOOP-19033. S3A: disable checksums when fs.s3a.checksum.validation == false Add new option fs.s3a.checksum.validation, default false, which is used when creating s3 clients.