Re: [PR] HADOOP-19038. Improve create-release RUN script. [hadoop]

2024-01-18 Thread via GitHub
slfan1989 merged PR #6448: URL: https://github.com/apache/hadoop/pull/6448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] HADOOP-19038. Improve create-release RUN script. [hadoop]

2024-01-18 Thread via GitHub
slfan1989 commented on PR #6448: URL: https://github.com/apache/hadoop/pull/6448#issuecomment-1898278315 @steveloughran @Hexiaoqiao Thanks for reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HADOOP-19038. Improve create-release RUN script. [hadoop]

2024-01-17 Thread via GitHub
slfan1989 commented on PR #6448: URL: https://github.com/apache/hadoop/pull/6448#issuecomment-1897876438 @Hexiaoqiao Can you help review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] HADOOP-19038. Improve create-release RUN script. [hadoop]

2024-01-16 Thread via GitHub
slfan1989 commented on code in PR #6448: URL: https://github.com/apache/hadoop/pull/6448#discussion_r1453537205 ## dev-support/bin/create-release: ## @@ -504,9 +504,9 @@ function dockermode echo "LABEL org.apache.hadoop.create-release=\"cr-${RANDOM}\"" # setup owners

Re: [PR] HADOOP-19038. Improve create-release RUN script. [hadoop]

2024-01-16 Thread via GitHub
slfan1989 commented on code in PR #6448: URL: https://github.com/apache/hadoop/pull/6448#discussion_r1453537205 ## dev-support/bin/create-release: ## @@ -504,9 +504,9 @@ function dockermode echo "LABEL org.apache.hadoop.create-release=\"cr-${RANDOM}\"" # setup owners

Re: [PR] HADOOP-19038. Improve create-release RUN script. [hadoop]

2024-01-14 Thread via GitHub
Hexiaoqiao commented on code in PR #6448: URL: https://github.com/apache/hadoop/pull/6448#discussion_r1451701620 ## dev-support/bin/create-release: ## @@ -504,9 +504,9 @@ function dockermode echo "LABEL org.apache.hadoop.create-release=\"cr-${RANDOM}\"" # setup owner

Re: [PR] HADOOP-19038. Improve create-release RUN script. [hadoop]

2024-01-13 Thread via GitHub
hadoop-yetus commented on PR #6448: URL: https://github.com/apache/hadoop/pull/6448#issuecomment-1890483348 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[PR] HADOOP-19038. Improve create-release RUN script. [hadoop]

2024-01-13 Thread via GitHub
slfan1989 opened a new pull request, #6448: URL: https://github.com/apache/hadoop/pull/6448 ### Description of PR JIRA: HADOOP-19038. Improve create-release RUN script. Using `create-release` will create a docker image locally, but three of the RUN scripts may fail to e