steveloughran merged PR #6488:
URL: https://github.com/apache/hadoop/pull/6488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...
hadoop-yetus commented on PR #6488:
URL: https://github.com/apache/hadoop/pull/6488#issuecomment-1921659870
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
Hisoka-X commented on code in PR #6488:
URL: https://github.com/apache/hadoop/pull/6488#discussion_r1474348758
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:
##
@@ -526,6 +526,18 @@ public void testRenameDirectoryMoveTo
steveloughran commented on code in PR #6488:
URL: https://github.com/apache/hadoop/pull/6488#discussion_r1474327653
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:
##
@@ -526,6 +526,18 @@ public void testRenameDirectoryM
steveloughran commented on PR #6488:
URL: https://github.com/apache/hadoop/pull/6488#issuecomment-1916823954
those java links have convinced me; StreamCloser in the jdk does exactly
this.
If you can do a test for this -fine. but it may be too hard to write a test
for...in which case
Hisoka-X commented on PR #6488:
URL: https://github.com/apache/hadoop/pull/6488#issuecomment-1915953798
> testing?
Adding...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
Hisoka-X commented on code in PR #6488:
URL: https://github.com/apache/hadoop/pull/6488#discussion_r1470514489
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:
##
@@ -4077,6 +4077,7 @@ private interface StatisticsAggregator {
STAT
steveloughran commented on code in PR #6488:
URL: https://github.com/apache/hadoop/pull/6488#discussion_r146995
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:
##
@@ -4077,6 +4077,7 @@ private interface StatisticsAggregator {
hadoop-yetus commented on PR #6488:
URL: https://github.com/apache/hadoop/pull/6488#issuecomment-1906363541
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Hisoka-X opened a new pull request, #6488:
URL: https://github.com/apache/hadoop/pull/6488
### Description of PR
This PR fix StatisticsDataReferenceCleaner thread class loader leak problem.
Before start it we should make sure it can not reference class loader.
### How was t
10 matches
Mail list logo
